fix(conversation): improve workspace search#594
Open
CottChen wants to merge 4 commits into
Open
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion backend changes for iOfficeAI/AionUi#3539.
This PR improves workspace search used by the project panel:
ignore::WalkBuilderso.gitignoreand git excludes are respected..git,node_modules,target, anddist.all,name, andcontent.Why
The AionUi project panel now exposes scoped search, search modes, and search result counts. Those UI behaviors depend on the backend returning recursive, mode-aware search results with match-kind metadata. The default pruning avoids accidentally walking dependency/build directories while keeping explicit scoped searches possible.
Tradeoffs
The search remains bounded by the existing result limit and is optimized for interactive project-panel usage rather than full indexing. This keeps the implementation simple and avoids background index state, at the cost of doing a fresh walk per query.
Local Checks
cargo fmt --all --checkcargo test -p aionui-conversation browse_workspace_search_cargo clippy -p aionui-conversation -- -D warnings