Fix flagged PHPCS throughout codebase#43
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sanitize_key() and sanitize_text_field() are unsuitable for the search value: the former strips spaces and punctuation, the latter trims whitespace. The value is hand-sanitized over the following lines instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The suggested wp_strip_all_tags() always trim()s its result, which would defeat the deliberate whitespace preservation noted above. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tomjn
reviewed
Jun 23, 2026
pamprn09
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will also serve as a test of the CI added in #42
Note
Specifically does not resolve get_block_wrapper_attributes warnings, which are a false positive, and will be resolved in humanmade/coding-standards#340
(Update, brought in HMCS 2.2.1 to resolve)