asb-plugin-font: Use Harfbuzz to deal with RTL text for icons/screenshots#497
Open
tagoh wants to merge 3 commits into
Open
asb-plugin-font: Use Harfbuzz to deal with RTL text for icons/screenshots#497tagoh wants to merge 3 commits into
tagoh wants to merge 3 commits into
Conversation
This change aims to improve a text in summary and the order of screenshots for Regular style of fonts. Removing a direct dependency to FreeType as a side-effect. Fixes hughsie#493
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cairo doesn't support RTL text. So giving cairo_glyph_t instance through harfbuzz-cairo to cairo.
Checking with google-noto-fonts, the number of icon files without this patch was:
and with this patch:
Please note that this patch is based on #496