[pull] memtable_as_log_index from topling:memtable_as_log_index - #17
Merged
pull[bot] merged 7 commits intoJul 28, 2026
Merged
Conversation
get_context_stats_ is only constructed when statistics != nullptr; reading it unconditionally is undefined when statistics is disabled.
On the non-writev memtable_as_log_index path, a failed payload Append must not advance log_offset_. Also enlarge error message buffers to be safely large for all %zd expansions.
Avoid retaining stale bound PMFs from a previous iterator when the wrapper is reset to null.
Fiber MultiGet has no TIMESTAMP unit coverage; document confirmed gaps and an audit checklist before enabling that path.
MaybeAddUserDefinedTimestampSizeRecord failure must release the manual_wal_flush lock when it was acquired before returning.
…date db_bench_enterprise.yaml now registers DBOptions under "default", so side_plugin_repo_get_db_options(..., "dbo") fails the easy conf check.
Stop forcing -fuse-ld=gold; probe the effective linker and skip ROCKSDB_STATIC_TLS in AggMerge when gold is used without LTO, where function-scope thread_local IE GOT slots can be wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )