Sync from Fork repo#8
Open
venkatareddyboya-highspot wants to merge 777 commits into
Open
Conversation
Mouli-Namburu
approved these changes
Mar 7, 2025
espresso3389
force-pushed
the
master
branch
2 times, most recently
from
a4af6b3 to
80f4c96
Compare
espresso3389
force-pushed
the
master
branch
2 times, most recently
from
5748e8d to
6964170
Compare
espresso3389
force-pushed
the
master
branch
6 times, most recently
from
93e3826 to
e809415
Compare
espresso3389
force-pushed
the
master
branch
11 times, most recently
from
2e34c97 to
6bd3d1a
Compare
espresso3389
force-pushed
the
master
branch
2 times, most recently
from
e70f7b0 to
09a9ff3
Compare
When PDF text begins with a newline character, `outputCharRects` is empty at the point where the code tries to access `outputCharRects.last`, causing a StateError (Bad state: No element). Add `isNotEmpty` check to guard against this edge case. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ing-newline Fix crash in loadStructuredText when text starts with newline
When a PDF document is disposed while background operations (page loading, font checking) are still in progress, calling subject.add() on a closed stream throws a StateError. Add isDisposed checks before emitting events in _notifyMissingFonts, _notifyDocumentLoadComplete, and the pages setter. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…pose Fix stream closed crash on document dispose race condition
Fix pdfrxInitialize race condition
PdfDocumentListenable._progress() calls notifyListeners() on every downloaded HTTP chunk during range-access loading. The viewer's _onDocumentChanged listener unconditionally releases all cached page images (releaseAllImages), clears layout, and sets _initialized=false on EVERY notification — even when the document reference hasn't changed. With preferRangeAccess enabled on a large PDF, hundreds of chunks arrive during and after loading. Each triggers a full nuclear reset, causing rendered pages to flash white repeatedly and preventing stable rendering. Fix: add an early return at the top of _onDocumentChanged() that skips the reset when the document reference is the same object. This correctly distinguishes progress-only notifications from actual document changes (initial load, document swap, error/null).
…ss-notification fix: skip full viewer reset on progress-only notifications
Fix pdfrxInitialize calls in tests failing on macOS
…gression [codex] Add macOS Flutter test regression coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.