-
Notifications
You must be signed in to change notification settings - Fork 3.7k
docs(prompting): add colour grading and film effects chapter #2911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vanceingalls
wants to merge
4
commits into
main
Choose a base branch
from
docs/color-grading-chapter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
819ed63
docs(prompting): add colour grading and film effects chapter
vanceingalls 2517f17
docs(guides): link colour grading agent guidance to the prompt chapter
vanceingalls e4eac0c
docs: address review on the color grading chapter
vanceingalls dd9c86d
docs: correct the --hf-color-grading-intensity claim
vanceingalls File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Blocker — the
--hf-color-grading-*CSS custom property system doesn't exist in the runtime code. Grepping the wholehyperframesrepo for--hf-color-gradingreturns zero matches outside these.mdxfiles.packages/core/src/runtime/colorGrading.ts:268(readColorGradingAttribute) reads onlyHF_COLOR_GRADING_ATTR(=data-color-grading) and resolves$variablerefs via__hfVariables(seereadVariablesForElementinruntime/variableScope.ts— reads onlywindow.__hfVariables*, no CSS custom-property read). TheMutationObserverat:255filters by[HF_COLOR_GRADING_ATTR]— not style. TheMutationObserveron the style attribute at:1519computes ageometrySignatureoftransform | translate | rotate | scale | left | top | width | heightonly — nevergetPropertyValue('--hf-...'). Sotl.to('#plate', { '--hf-color-grading-pixelate': 0.5 })writes a CSS variable that nothing consumes.If there's a code path where these custom properties get consumed that I couldn't locate, point at it — otherwise this whole section documents an unshipped feature. The payload-rewrite path (
setAttribute('data-color-grading', ...)) IS backed by the MutationObserver at:255, and thehalftone/twoInkPrintverification below confirms it works. Recommend collapsing the entire "Animating a Grade" section to the payload-rewrite pattern only — drop the 9-CSS-custom-property list and thetl.to()example, keep thedata-color-gradingonUpdateexample.— Rames D Jusso