Skip to content

refactor(vst): split oversized files and dedupe CLI/engine code to clear fallow gate - #2603

Closed
vanceingalls wants to merge 1 commit into
vo-carve-featurefrom
vo-carve-fallow-cleanup
Closed

refactor(vst): split oversized files and dedupe CLI/engine code to clear fallow gate#2603
vanceingalls wants to merge 1 commit into
vo-carve-featurefrom
vo-carve-fallow-cleanup

Conversation

@vanceingalls

@vanceingalls vanceingalls commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

What

Splits the oversized files this branch added or grew past the repo's 600-line filesize cap, and dedupes code the repo's fallow gate flagged as newly-introduced duplication/complexity:

  • propertyPanelVstSection.tsx (816→429 lines) → propertyPanelVstShared.ts, propertyPanelVstCarveSection.tsx, propertyPanelVstPluginRows.tsx
  • useVstHost.ts (673→356 lines) → vstHostWire.ts (protocol parsing, pending-request bookkeeping, socket connect sequence)
  • useVstPreview.ts (806→397 lines) → useVstPreviewHelpers.ts (load-scan orchestration, track lifecycle, PCM decode)
  • Decomposes timelineIframeHelpers.ts's flagged autoHealMissingCompositionIds and buildMissingCompositionElements
  • Dedupes parseIntFlag/parsePositiveInt/parseEnum + the sites create verb guard shared by lambda.ts/cloudrun.ts into utils/distributedRenderFlags.ts
  • Dedupes the ffmpeg-timeout/output-dir/result-building boilerplate shared by audioMixer.ts's extract/prepare/silence helpers
  • Extracts shared test-render boilerplate (testRenderUtils.tsx) across the propertyPanelFlat*.test.tsx family, plus per-file test fixtures (vstSidecarTestFixture.ts, vstSocketTestFixture.ts) elsewhere

Why

All of the above is pure extraction/dedup with no behavior change, needed to clear the repo's fallow static-analysis gate (complexity/duplication/filesize) before this branch could land.

Test plan

  • fallow audit passes clean (0 introduced complexity/duplication/dead-code findings)
  • Full monorepo build succeeds
  • Full test suite passes across studio/engine/cli/vst-host

🤖 Generated with Claude Code

…ear fallow gate

Splits propertyPanelVstSection.tsx (816->429 lines) into
propertyPanelVstShared.ts, propertyPanelVstCarveSection.tsx, and
propertyPanelVstPluginRows.tsx; useVstHost.ts (673->356 lines) into
vstHostWire.ts (protocol parsing, pending-request bookkeeping, socket
connect sequence); useVstPreview.ts (806->397 lines) into
useVstPreviewHelpers.ts (load-scan orchestration, track lifecycle,
PCM decode). Decomposes timelineIframeHelpers.ts's flagged
autoHealMissingCompositionIds and buildMissingCompositionElements.
Dedupes parseIntFlag/parsePositiveInt/parseEnum and the sites-create
verb guard shared by lambda.ts/cloudrun.ts into
utils/distributedRenderFlags.ts, and the ffmpeg-timeout/output-dir/
result-building boilerplate shared by audioMixer.ts's extract/prepare/
silence helpers. Extracts shared test-render boilerplate (testRenderUtils.tsx)
across the propertyPanelFlat*.test.tsx family and per-file test fixtures
(vstSidecarTestFixture.ts, vstSocketTestFixture.ts) elsewhere.

Also fixes two 600-line filesize-gate regressions introduced while
reconciling this work against an updated origin/main: extracts
removeBackgroundViaApi out of StudioRightPanel.tsx, and drops a dead
re-export block from PropertyPanel.tsx (its only consumer already had
the real source available directly).

All of the above is pure extraction/dedup — no behavior change. Verified:
fallow audit passes clean (0 introduced complexity/duplication/dead-code
findings), full monorepo build succeeds, and the full test suite passes
across studio/engine/cli/vst-host.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vanceingalls

Copy link
Copy Markdown
Collaborator Author

Superseded by a recut stack: #2919#2920#2921#2922#2923.

Same net result (68 files, +8,632/-491) with the add-then-delete churn removed and rebased onto current main (this stack's merge-base was 519 commits behind). Leaving these open until the new stack is reviewed.

Per-PR deletions now: 122 (a net-negative refactor), 1, 297, 15, 54 — all real edits against main, none of it code an earlier PR in the stack had added.

@vanceingalls

Copy link
Copy Markdown
Collaborator Author

Closing in favor of the recut stack: #2919#2920#2921#2922#2923.

Same net result (68 files, +8,632/-491), rebased onto current main, with the add-then-delete churn removed — packages/vst-host/ is never added and then deleted, files arrive pre-split, and the feature flag lands with the first studio commit instead of trailing the stack.

Branches are left in place; nothing is deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant