refactor(vst): split oversized files and dedupe CLI/engine code to clear fallow gate - #2603
refactor(vst): split oversized files and dedupe CLI/engine code to clear fallow gate#2603vanceingalls wants to merge 1 commit into
Conversation
…ear fallow gate Splits propertyPanelVstSection.tsx (816->429 lines) into propertyPanelVstShared.ts, propertyPanelVstCarveSection.tsx, and propertyPanelVstPluginRows.tsx; useVstHost.ts (673->356 lines) into vstHostWire.ts (protocol parsing, pending-request bookkeeping, socket connect sequence); useVstPreview.ts (806->397 lines) into useVstPreviewHelpers.ts (load-scan orchestration, track lifecycle, PCM decode). Decomposes timelineIframeHelpers.ts's flagged autoHealMissingCompositionIds and buildMissingCompositionElements. Dedupes parseIntFlag/parsePositiveInt/parseEnum and the sites-create verb guard shared by lambda.ts/cloudrun.ts into utils/distributedRenderFlags.ts, and the ffmpeg-timeout/output-dir/ result-building boilerplate shared by audioMixer.ts's extract/prepare/ silence helpers. Extracts shared test-render boilerplate (testRenderUtils.tsx) across the propertyPanelFlat*.test.tsx family and per-file test fixtures (vstSidecarTestFixture.ts, vstSocketTestFixture.ts) elsewhere. Also fixes two 600-line filesize-gate regressions introduced while reconciling this work against an updated origin/main: extracts removeBackgroundViaApi out of StudioRightPanel.tsx, and drops a dead re-export block from PropertyPanel.tsx (its only consumer already had the real source available directly). All of the above is pure extraction/dedup — no behavior change. Verified: fallow audit passes clean (0 introduced complexity/duplication/dead-code findings), full monorepo build succeeds, and the full test suite passes across studio/engine/cli/vst-host. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Superseded by a recut stack: #2919 → #2920 → #2921 → #2922 → #2923. Same net result (68 files, +8,632/-491) with the add-then-delete churn removed and rebased onto current Per-PR deletions now: 122 (a net-negative refactor), 1, 297, 15, 54 — all real edits against |
|
Closing in favor of the recut stack: #2919 → #2920 → #2921 → #2922 → #2923. Same net result (68 files, +8,632/-491), rebased onto current Branches are left in place; nothing is deleted. |

What
Splits the oversized files this branch added or grew past the repo's 600-line filesize cap, and dedupes code the repo's fallow gate flagged as newly-introduced duplication/complexity:
propertyPanelVstSection.tsx(816→429 lines) →propertyPanelVstShared.ts,propertyPanelVstCarveSection.tsx,propertyPanelVstPluginRows.tsxuseVstHost.ts(673→356 lines) →vstHostWire.ts(protocol parsing, pending-request bookkeeping, socket connect sequence)useVstPreview.ts(806→397 lines) →useVstPreviewHelpers.ts(load-scan orchestration, track lifecycle, PCM decode)timelineIframeHelpers.ts's flaggedautoHealMissingCompositionIdsandbuildMissingCompositionElementsparseIntFlag/parsePositiveInt/parseEnum+ thesites createverb guard shared bylambda.ts/cloudrun.tsintoutils/distributedRenderFlags.tsaudioMixer.ts's extract/prepare/silence helperstestRenderUtils.tsx) across thepropertyPanelFlat*.test.tsxfamily, plus per-file test fixtures (vstSidecarTestFixture.ts,vstSocketTestFixture.ts) elsewhereWhy
All of the above is pure extraction/dedup with no behavior change, needed to clear the repo's fallow static-analysis gate (complexity/duplication/filesize) before this branch could land.
Test plan
🤖 Generated with Claude Code