fix(ui): weight change-ID prefixes and enlarge file paths (#274) - #286
Merged
Merged
Conversation
hewigovens
added this pull request to stack #288
September 19, 2026 01:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
hewigovens
force-pushed
the
polish-rows
branch
2 times, most recently
from
September 19, 2026 02:30
5ad3bc9 to
3735b0e
Compare
File rows render the path at 10 pt monospace instead of 9 pt, a step below the 12 pt name so it stays secondary, and every short id drawn through ShortId.highlighted now bolds the shortest-unique prefix in the change-id color and leaves the remainder regular and secondary, matching the GPUI shell; a per-run weight needs an explicit font, so callers pass one resolved from the user's font-size and mono-family settings via AppSettings.MonoFont.scaledFont, which also backs jayjayFont so both paths share a single formula, and identifierFont names the one nominal size short ids use everywhere.
hewigovens
force-pushed
the
polish-rows
branch
from
September 19, 2026 07:43
3735b0e to
1dea310
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File rows render the path at 11 pt monospace instead of 9 pt, and every short id drawn through ShortId.highlighted now bolds the shortest-unique prefix in the change-id color and leaves the remainder regular and secondary, matching the GPUI shell; a per-run weight needs an explicit font, so callers pass one resolved from the user's font-size and mono-family settings via AppSettings.MonoFont.scaledFont, which also backs jayjayFont so both paths share a single formula.
Part of #274 (rows half; the detail-pane half is stacked on this PR). Part of #270.
Side effect worth knowing: with a custom mono font,
jayjayFontweights were silently dropped before and now apply. The default system path is unchanged.Before / after
Same fixture, same selection, 2x. Before is current main.
Light
Before
After
Dark
Before
After