fix(ui): align graph nodes and inline symbols to their text (#271) - #278
Merged
Merged
Conversation
The DAG node was painted at a fixed 12 pt offset, about 3.5 pt above the change-ID line at the default font and further off as the font-size setting grows; it now centers on the refs row's measured bounds, which an anchor preference hands to the new DAGGraphColumn view. Icon and label pairs align on the first text baseline in the DAG chips, the description Edit button (its pencil now matches the label size), copyable rows, file rows, and the toolbar Bookmarks button, which also gains the horizontal inset its neighbours have; the file status dot anchors to the filename line instead of the two-line block. Chips carrying an SF Symbol were up to 13% taller than text-only chips and the tag symbol pushed its own label a point off the line, so symbols now draw at the small scale and the refs row aligns on the baseline, giving every chip one height.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DAG node was painted at a fixed 12 pt offset, about 3.5 pt above the change-ID line at the default font and further off as the font-size setting grows; it now centers on the refs row's measured bounds, which an anchor preference hands to the new DAGGraphColumn view. Icon and label pairs align on the first text baseline in the DAG chips, the description Edit button (its pencil now matches the label size), copyable rows, file rows, and the toolbar Bookmarks button, which also gains the horizontal inset its neighbours have; the file status dot anchors to the filename line instead of the two-line block. Chips carrying an SF Symbol were up to 13% taller than text-only chips and the tag symbol pushed its own label a point off the line, so symbols now draw at the small scale and the refs row aligns on the baseline, giving every chip one height.
Closes #271. Part of #270. Stacked under the #272 PR, which builds on this one.
Before / after
Same fixture repo, same selection, revset bar shown, 2x. Before is 0.3.18-beta.2; after is this stack with #272 included.
Light
Before
After
Dark
Before
After