Skip to content

feat: add multi-selection diffs and batch change actions - #186

Open
hewigovens wants to merge 2 commits into
mainfrom
h/multi-selection-actions
Open

feat: add multi-selection diffs and batch change actions#186
hewigovens wants to merge 2 commits into
mainfrom
h/multi-selection-actions

Conversation

@hewigovens

Copy link
Copy Markdown
Owner

Summary

  • share ordered selection behavior across the SwiftUI and GPUI DAG, file list, and evolog
  • show combined diffs for consecutive changes and guidance for non-consecutive selections
  • add topology-gated merge, squash, abandon, and rebase actions for selected changes
  • render evolog interdiff files in GPUI and guard asynchronous selection updates

Part of #168.

Testing

  • full GPUI suite: 210 unit tests and 311 component tests
  • focused Rust core batch-mutation and combined-diff tests
  • focused Swift model and XCUITest multi-selection/evolog scenes
  • just lint

Visuals

Draft for CI. Add a screenshot or demo before marking ready for review.

@hewigovens
hewigovens marked this pull request as ready for review August 30, 2026 13:01
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T08:43:18.977541Z d453ee1 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hewigovens
hewigovens force-pushed the h/multi-selection-actions branch from be15aa0 to 67d9356 Compare August 30, 2026 13:10

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be15aa0f71

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/jayjay-core/src/repo/revsets.rs
Comment thread shell/mac/Sources/JayJay/Repo/ViewModel/Core/RepoViewModel.swift
Comment thread crates/jayjay-core/src/repo/mutations.rs
Comment thread shell/mac/Sources/JayJay/Repo/DAG/DAGView.swift
Comment thread shell/gpui/src/repo/view_model/selection.rs Outdated
@hewigovens
hewigovens force-pushed the h/multi-selection-actions branch from 67d9356 to 12c2dcf Compare August 30, 2026 13:29
Share ordered selection behavior across the SwiftUI DAG, file list, and evolog. Show combined diffs for consecutive changes, explain non-consecutive selections, and add topology-gated merge, squash, abandon, and rebase actions backed by the Rust core.
Mirror the multi-selection and batch-action workflow in GPUI. Reuse one ordered-selection model for DAG, evolog, and file rows, render evolog interdiffs, and cover combined diffs, topology-gated menus, confirmations, and selection cleanup.
@hewigovens
hewigovens force-pushed the h/multi-selection-actions branch from 12c2dcf to d453ee1 Compare August 31, 2026 08:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d453ee1ca4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/jayjay-core/src/repo/mutations.rs
Comment thread shell/gpui/src/repo/view_model/selection.rs
Comment thread shell/gpui/src/repo/view_model/selection.rs
Comment thread shell/gpui/src/windows/evolog/diff.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant