More pane size persistence - #183
Open
lookbusy1344 wants to merge 3 commits into
Open
Conversation
Keep the snapshot and filename pane widths in persisted app settings and stable view state so loading another evolution snapshot no longer restores split-view defaults. Add a deterministic XCUITest fixture and regression scene covering snapshot switches and app relaunches.
Owner
|
For 2 and 3, no need to persistent imho, they're good default values; can you reuse FileColumn width constant (rename to make it generic) and preference for Evolog too? no need to have another value. |
Contributor
Author
No problem I’ll update this in the next couple of hours! |
Instead of two persisted evolog widths, both the entry-list and file-list dividers read and write the same PaneLayout.secondaryPaneWidth preference the change-detail file column already uses, renamed from fileColumn to reflect that. One shared value, one shared default; no need for evolog-specific persistence.
The interdiff file list is a third pane in a snapshot/filenames/preview split, not the two-pane layout secondaryPaneWidth is tuned for. It still sizes from that shared preference by default, but no longer writes its own drags back to it, so resizing it doesn't change the default the file column and evolog entry list restore to.
lookbusy1344
force-pushed
the
pane-size-persistence
branch
from
August 31, 2026 08:34
98dbdcd to
a2915aa
Compare
Contributor
Author
|
Ok so now we're sharing evolog width with the normal file list (renamed to secondaryPaneWidth to make it generic), and it's also shared with any third pane (like looking at files in a snapshot), but for the third pane any adjustment isn't written back to the default. How's it look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed evolog pane width adjustments were not preserved. This branch persists evolog snapshot-list pane width, sharing width with the normal file list. The same width is also used for any third pane (eg files in a snapshot).