Skip to content

Improve for dev#23

Merged
baxyz merged 24 commits intomainfrom
improve-for-dev
Apr 30, 2026
Merged

Improve for dev#23
baxyz merged 24 commits intomainfrom
improve-for-dev

Conversation

@baxyz
Copy link
Copy Markdown
Contributor

@baxyz baxyz commented Apr 30, 2026

Description

Please include a summary of what this PR does and why it's needed.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring
  • Test improvement

Related Issues

Closes #(issue number)

How Has This Been Tested?

Describe the tests you ran and how to reproduce them:

  • Test A
  • Test B

Checklist

  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I have added tests for my changes
  • All new and existing tests passed locally
  • My commits follow the conventional commit format

Screenshots (if applicable)

Add screenshots for UI changes.

Additional Context

Add any other context about the PR here.

baxyz added 2 commits April 30, 2026 20:35
- include ms-vscode.remote-repositories for remote repo access
- update version history in README
Copilot AI review requested due to automatic review settings April 30, 2026 20:38
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the github-dev devcontainer feature to adjust the default VS Code extension set and bump the feature version, keeping repository docs in sync with the feature metadata.

Changes:

  • Bump github-dev feature version to 1.0.1.
  • Remove github.copilot from the default extension list and add ms-vscode.remote-repositories.
  • Update github-dev documentation and the feature table entry in AGENTS.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/github-dev/devcontainer-feature.json Version bump and extension list update (remove github.copilot, add ms-vscode.remote-repositories).
src/github-dev/README.md Reflect updated extension list and add v1.0.1 changelog note.
AGENTS.md Update the “Available Features” table entry for github-dev to 1.0.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/github-dev/README.md
Comment thread src/github-dev/README.md
Comment thread AGENTS.md Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

✅ PR Validation Passed

All checks passed!


📋 Pipeline Status

Job Status
🧾 Conventional Commits passing
🧪 Feature Tests passing
🐚 ShellCheck passing

🤖 Generated by @helpers4 CI • 2026-04-30

@baxyz baxyz force-pushed the improve-for-dev branch from 7b2aa26 to 001a8fb Compare April 30, 2026 21:14
baxyz added 3 commits April 30, 2026 21:33
- bump version to 1.1.0
- add support for syncing cloud credentials (AWS, kube, Docker, gh OAuth)
- enhance README and documentation for clarity
- implement copy-if-absent strategy for additional config files
@baxyz baxyz force-pushed the improve-for-dev branch from b8cd327 to 6f1f4c8 Compare April 30, 2026 21:40
baxyz and others added 5 commits April 30, 2026 21:45
Co-authored-by: Copilot <copilot@github.com>
- add detection of features with version changes
- implement forced republishing of all features
- create per-feature git tags upon release
- trigger website updates for each feature
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 10 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/auto-header/test.sh Outdated
Comment thread src/dotfiles-sync/install.sh Outdated
Comment thread src/auto-header/install.sh
Comment thread src/dotfiles-sync/devcontainer-feature.json
Comment thread src/dotfiles-sync/sync-files.sh
Comment thread src/dotfiles-sync/sync-files.sh Outdated
Comment thread .github/workflows/release.yml
Comment thread .vscode/settings.json
Comment thread src/auto-header/install.sh Outdated
Comment thread src/auto-header/install.sh Outdated
@baxyz baxyz force-pushed the improve-for-dev branch from 52cff5b to 3494f90 Compare April 30, 2026 22:39
baxyz added 2 commits April 30, 2026 22:57
…hAuth

BREAKING CHANGE: option syncGhAuth is removed and only ~/.config/gh/config.yml (single file) is bind-mounted now. The previous directory-level mount exposed hosts.yml (GitHub OAuth token) inside /tmp/dotfiles-sync regardless of the opt-in. Use github-dev with GH_TOKEN env, or run gh auth login in the container.
@baxyz baxyz force-pushed the improve-for-dev branch from cb3702e to a87571e Compare April 30, 2026 23:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 12 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/dotfiles-sync/devcontainer-feature.json
Comment thread src/dotfiles-sync/devcontainer-feature.json
Comment thread src/dotfiles-sync/sync-files.sh
Comment thread src/dotfiles-sync/README.md
Comment thread src/local-mounts/README.md
Comment thread src/dotfiles-sync/README.md
Comment thread AGENTS.md
Comment thread test/dotfiles-sync/test.sh
Comment thread src/vite-plus/install.sh
Comment thread src/vite-plus/install.sh
baxyz added 2 commits April 30, 2026 23:31
…ources

- auto-header: persist resolved machineSettingsFile path in config.json so test reads the same path the installer wrote (build-time _REMOTE_USER differs from test-time fallback on images without node user).
- pr-validation.yml: create all 14 bind-mount source paths required by dotfiles-sync feature, not just gitconfig/npmrc/ssh/gnupg, so docker run no longer aborts on missing /home/runner/.gitignore_global etc.
@baxyz baxyz merged commit 5712f46 into main Apr 30, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants