Skip to content

feat(tooling): soup hotfiles check in driver-rebuild --verify - #77

Open
heavygee wants to merge 1 commit into
mainfrom
fix/soup-hotfiles-verify-gate
Open

feat(tooling): soup hotfiles check in driver-rebuild --verify#77
heavygee wants to merge 1 commit into
mainfrom
fix/soup-hotfiles-verify-gate

Conversation

@heavygee

@heavygee heavygee commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds hapi-soup-hotfiles-check.mjs (syncEngine→rpcGateway parity + codex route guard)
  • Writes ~/.config/hapi/driver-verify-stamp on successful --verify
  • Documents layer-collision repair pattern in driver-soup.md

Test plan

  • hotfiles check on homelab + guest driver
  • hapi-driver-rebuild --build-web --verify green on guest

Made with Cursor

Add hapi-soup-hotfiles-check.mjs (syncEngine rpcGateway call parity + codex
route). Write ~/.config/hapi/driver-verify-stamp on successful verify.
Document layer-collision repair pattern in driver-soup.md.

Co-authored-by: Cursor <cursoragent@cursor.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 466d8b4e56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +22 to +23
const calls = [...new Set([...syncEngine.matchAll(/this\.rpcGateway\.(\w+)\(/g)].map((m) => m[1]))]
const methods = new Set([...rpcGateway.matchAll(/^\s+async (\w+)\(/gm)].map((m) => m[1]))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include generic calls in the parity scan

When syncEngine calls a generic gateway method with type arguments, as it already does with this.rpcGateway.callPiRpc<T>(...), this scan requires the method name to be followed immediately by ( and the method definition pattern has the same limitation for async callPiRpc<T = unknown>(...). In that collision case the new hot-file gate can still print OK while a generic rpcGateway call/method pair is missing from the advertised syncEnginerpcGateway parity check.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant