Conversation
Replace the bespoke single-select namespace dropdown on the Installed view with Headlamp's SectionFilterHeader, so the selection is the same multi-select control used across the app and survives navigation between Helm releases and native views. The store already persists it per cluster and mirrors it into the ?namespace= query param. Read filter.namespaces through react-redux rather than importing useNamespaces from lib/redux/filterSlice: that path is not in the plugin bundler's externals map and resolves to an undefined global at runtime. This follows the existing metal3 and flux plugins. Namespace options now come from the cluster instead of being derived from the loaded releases, so listing namespaces requires the matching RBAC. Signed-off-by: Quent1L <quentin-ol@ik.me>
Quent1L
requested review from
ashu8912,
illume,
joaquimrocha,
skoeva,
sniok,
vyncent-t and
yolossn
as code owners
September 4, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Installed view of the
app-catalogplugin (Apps → Installed) used its own namespace filter: a bespoke single-select MUIAutocompletebacked by local component state. This made it inconsistent with the rest of Headlamp, where every list view shares one multi-select namespace filter.Concretely, the old control:
This PR replaces it with Headlamp's shared filter.
SectionHeaderbecomesSectionFilterHeader, which appends the standardNamespacesAutocomplete. The selection now lives in the globalfilter.namespacesstore, so it is multi-select, persisted per cluster inlocalStorage, mirrored into the?namespace=query parameter, and preserved when moving between the Helm views and the rest of Headlamp.Behaviour change
Namespace options now come from the cluster (
Namespace.useList(), orallowedNamespacesfrom the cluster settings) instead of being derived from the loaded releases. That is the point of the change, but it means namespaces without releases appear in the dropdown, and listing namespaces requires the matching RBAC.Steps to Test
?namespace=<ns1> <ns2>.localStorage.…/apps/installed?namespace=<some-ns>directly in a fresh tab. That namespace is selected on first load.