Conversation
Signed-off-by: Sumit Goyal <rjsumit71@gmail.com>
itvi-1234
requested review from
ashu8912,
illume,
joaquimrocha,
skoeva,
sniok,
vyncent-t and
yolossn
as code owners
August 27, 2026 17:47
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Gateway status fixture is discarded and the new E2E suite is not executed by CI.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Adds a KWOK-backed Playwright E2E suite for validating Kmesh plugin workflows in Headlamp.
Changes:
- Adds cluster setup, fixtures, and Headlamp container orchestration.
- Tests Waypoints and Node Security views.
- Adds Playwright dependencies and scripts.
| File | Description |
|---|---|
kmesh/package.json |
Adds E2E scripts and dependencies. |
kmesh/package-lock.json |
Locks new dependencies. |
kmesh/e2e/run-kmesh-e2e.ts |
Orchestrates the E2E environment. |
kmesh/e2e/README.md |
Documents E2E usage. |
kmesh/e2e/playwright.config.ts |
Configures Playwright. |
kmesh/e2e/kwok-fixtures.yaml |
Defines test resources. |
kmesh/e2e/kmesh.spec.ts |
Implements UI scenarios. |
kmesh/e2e/kmesh-crds.yaml |
Defines the Kmesh test CRD. |
kmesh/e2e/gateway-crd.yaml |
Vendors the Gateway CRD. |
kmesh/e2e/Dockerfile.headlamp |
Builds the test Headlamp image. |
Files not reviewed (1)
- kmesh/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+67
to
+71
| status: | ||
| conditions: | ||
| - type: Programmed | ||
| status: 'True' | ||
| reason: Programmed |
| "storybook-build": "headlamp-plugin storybook-build", | ||
| "test": "headlamp-plugin test", | ||
| "test": "vitest run --config node_modules/@kinvolk/headlamp-plugin/config/vite.config.mjs --exclude \"**/node_modules/**\" --exclude \"e2e/**\"", | ||
| "e2e": "node --import tsx e2e/run-kmesh-e2e.ts", |
|
|
||
| export default defineConfig({ | ||
| testDir: e2eDir, | ||
| outputDir: path.join(e2eDir, 'test-results'), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ai-assistant/e2e.KmeshNodeInfoCRD, with fixtures: a WaypointGateway, and twoKmeshNodeInfonodes with a deliberate SPI mismatch.Programmedcondition → Node Security list correctly flagging the SPI mismatch between nodes.npm run e2e/npm run e2e:playwrightscripts and the required devDependencies (@playwright/test,tsx,js-yaml); excludese2e/**from the unit-test (vitest) run so they don't collide.