Skip to content

Upgrade to latest lsp / lsp-types / lsp-test#4166

Merged
jhrcek merged 5 commits into
masterfrom
jan/upgrade-lsp
Apr 30, 2024
Merged

Upgrade to latest lsp / lsp-types / lsp-test#4166
jhrcek merged 5 commits into
masterfrom
jan/upgrade-lsp

Conversation

@jhrcek

@jhrcek jhrcek commented Apr 7, 2024

Copy link
Copy Markdown
Collaborator

New version of lsp* has not been released yet, but I upgraded hls codebase to master version to be able to test haskell/lsp#566

UPDATE: we're not going to merge the "disable progress messages" PR in lsp repo,
but this PR can still be used because it contains all the fixes to breaking changes in lsp repo.

@soulomoon

soulomoon commented Apr 28, 2024

Copy link
Copy Markdown
Collaborator

Is the new lsp released yet, can't wait to use it since
testing the #4194 is causing a lot of 3 second wait 0 0

@jhrcek

jhrcek commented Apr 28, 2024

Copy link
Copy Markdown
Collaborator Author

It's not released yet. I just rebased this PR on master + switched to latest master commit of lsp repo.
It compiles, but there are bunch of test failures. I'll look at those over next week.

@jhrcek

jhrcek commented Apr 29, 2024

Copy link
Copy Markdown
Collaborator Author

@soulomoon @michaelpj updated to lsp master, I consider this ready to merge.
I'd suggest we release the latest changes in lsp repo to hackage and then switch this PR to use hackage releases of those packages and merge.

@michaelpj

Copy link
Copy Markdown
Collaborator

Yep, I'll do a release.

@soulomoon

Copy link
Copy Markdown
Collaborator

Great

@michaelpj

Copy link
Copy Markdown
Collaborator

Haha, I had just done that locally. You are very on it ;)

@jhrcek

jhrcek commented Apr 30, 2024

Copy link
Copy Markdown
Collaborator Author

That's what it's like having github notifications enabled and few minutes to spare between meetings 😄
Thanks for releasing new versions to hackage.

@jhrcek jhrcek marked this pull request as ready for review April 30, 2024 12:53

@michaelpj michaelpj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for dealing with all this, much appreciated.

@soulomoon soulomoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jhrcek jhrcek deleted the jan/upgrade-lsp branch May 11, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants