merge queue: checking master (f47e959), #12068 and #12054 together#12096
Closed
mergify[bot] wants to merge 4 commits into
Closed
merge queue: checking master (f47e959), #12068 and #12054 together#12096mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
This change fixes the binary format mismatch between the build rules producer and the consumer, resulting in `Missing ByteString argument in 'ruleExecCmd'` error during builds. When a hook creates a dynamic hook with a command for discovering dynamic dependencies, the hook creates a result of type ([Dependency], LBS.ByteString), but the consumer decodes it as Maybe ([Dependency], LBS.ByteString). Added a test case to SetupHooksNonHs that covers this scenario. Added changelog entry. Fixes #12053
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch master (f47e959), #12068 and #12054 are queued together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #12054.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:#review-threads-unresolved = 0[🛡 GitHub branch protection]runRuleDynDepsCmdbinary format mismatch #12054github-review-approved[🛡 GitHub branch protection]runRuleDynDepsCmdbinary format mismatch #12054check-success = Doctest Cabalcheck-neutral = Doctest Cabalcheck-skipped = Doctest Cabalcheck-success = Meta checkscheck-neutral = Meta checkscheck-skipped = Meta checkscheck-success = docs/readthedocs.org:cabalcheck-neutral = docs/readthedocs.org:cabalcheck-skipped = docs/readthedocs.org:cabalcheck-success = Validate post jobcheck-neutral = Validate post jobcheck-skipped = Validate post jobcheck-success = fourmolucheck-neutral = fourmolucheck-skipped = fourmolucheck-success = hlintcheck-neutral = hlintcheck-skipped = hlintcheck-success = Bootstrap post jobcheck-neutral = Bootstrap post jobcheck-skipped = Bootstrap post jobcheck-success = whitespacecheck-neutral = whitespacecheck-skipped = whitespacecheck-success = Check sdist post jobcheck-neutral = Check sdist post jobcheck-skipped = Check sdist post jobcheck-success = Changelogscheck-neutral = Changelogscheck-skipped = ChangelogsRequired conditions to stay in the queue:
#review-threads-unresolved = 0[🛡 GitHub branch protection]runRuleDynDepsCmdbinary format mismatch #12054github-review-approved[🛡 GitHub branch protection]runRuleDynDepsCmdbinary format mismatch #12054check-success = Doctest CabalrunRuleDynDepsCmdbinary format mismatch #12054check-neutral = Doctest CabalrunRuleDynDepsCmdbinary format mismatch #12054check-skipped = Doctest CabalrunRuleDynDepsCmdbinary format mismatch #12054check-success = Meta checksrunRuleDynDepsCmdbinary format mismatch #12054check-neutral = Meta checksrunRuleDynDepsCmdbinary format mismatch #12054check-skipped = Meta checksrunRuleDynDepsCmdbinary format mismatch #12054check-success = docs/readthedocs.org:cabalrunRuleDynDepsCmdbinary format mismatch #12054check-neutral = docs/readthedocs.org:cabalrunRuleDynDepsCmdbinary format mismatch #12054check-skipped = docs/readthedocs.org:cabalrunRuleDynDepsCmdbinary format mismatch #12054check-success = Validate post jobrunRuleDynDepsCmdbinary format mismatch #12054check-neutral = Validate post jobrunRuleDynDepsCmdbinary format mismatch #12054check-skipped = Validate post jobrunRuleDynDepsCmdbinary format mismatch #12054check-success = fourmolurunRuleDynDepsCmdbinary format mismatch #12054check-neutral = fourmolurunRuleDynDepsCmdbinary format mismatch #12054check-skipped = fourmolurunRuleDynDepsCmdbinary format mismatch #12054check-success = hlintrunRuleDynDepsCmdbinary format mismatch #12054check-neutral = hlintrunRuleDynDepsCmdbinary format mismatch #12054check-skipped = hlintrunRuleDynDepsCmdbinary format mismatch #12054check-success = Bootstrap post jobrunRuleDynDepsCmdbinary format mismatch #12054check-neutral = Bootstrap post jobrunRuleDynDepsCmdbinary format mismatch #12054check-skipped = Bootstrap post jobrunRuleDynDepsCmdbinary format mismatch #12054check-success = whitespacerunRuleDynDepsCmdbinary format mismatch #12054check-neutral = whitespacerunRuleDynDepsCmdbinary format mismatch #12054check-skipped = whitespacerunRuleDynDepsCmdbinary format mismatch #12054check-success = Check sdist post jobrunRuleDynDepsCmdbinary format mismatch #12054check-neutral = Check sdist post jobrunRuleDynDepsCmdbinary format mismatch #12054check-skipped = Check sdist post jobrunRuleDynDepsCmdbinary format mismatch #12054check-success = ChangelogsrunRuleDynDepsCmdbinary format mismatch #12054check-neutral = ChangelogsrunRuleDynDepsCmdbinary format mismatch #12054check-skipped = ChangelogsrunRuleDynDepsCmdbinary format mismatch #12054