Skip to content

Add a section for assertions and note marked output#12073

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:doc/marked-output-assertions
Jul 5, 2026
Merged

Add a section for assertions and note marked output#12073
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:doc/marked-output-assertions

Conversation

@philderbeast

@philderbeast philderbeast commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

A documentation change only, add a section for assertions in the haddocks for cabal-testsuite and explain that we can only make assertions about marked output.

As rendered:

image
  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@philderbeast

Copy link
Copy Markdown
Collaborator Author

With the module re-exporting itself, does anyone know how to avoid the duplication seen in the rendered docs of some functions like assertOutputContains?

@philderbeast philderbeast force-pushed the doc/marked-output-assertions branch from a67dda7 to c6ad8d4 Compare July 2, 2026 17:57
@philderbeast philderbeast added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jul 2, 2026
@philderbeast philderbeast force-pushed the doc/marked-output-assertions branch 2 times, most recently from c6ad8d4 to b0170f8 Compare July 2, 2026 21:04
@mergify mergify Bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Jul 3, 2026
@mergify

mergify Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 2 hours 36 minutes 59 seconds in the queue, including 1 hour 37 minutes 38 seconds running CI.

Required conditions to merge
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify Bot added a commit that referenced this pull request Jul 5, 2026
mergify Bot added a commit that referenced this pull request Jul 5, 2026
mergify Bot added a commit that referenced this pull request Jul 5, 2026
@mergify mergify Bot merged commit f47e959 into haskell:master Jul 5, 2026
89 of 91 checks passed
@mergify mergify Bot removed the queued label Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants