Repository navigation
Epic: Create issues to resolve CodeQL alerts 1- 24, 98 "Potentially unsafe external link" #5129
Description
Prerequisite
- Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
- Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.
Overview
We need to resolve CodeQL code alerts 1 - 24 of type Potentially unsafe external link.
Dependencies (child issues - this issue will remain open until all these issues are completed)
- Resolve CodeQL alert 1 "Potentially unsafe external link" #5673
- Resolve CodeQL alert 4 "Potentially unsafe external link #5674
- Resolve CodeQL alert 9 "Potentially unsafe external link" #6043
- Resolve CodeQL alert 5 and 7 "Potentially unsafe external link" #6226
- Resolve CodeQL alert 6 and 8 "Potentially unsafe external link" #6227
- Resolve CodeQL alert 3 "Potentially unsafe external link" #6044
- Resolve CodeQL alert 10 "Potentially unsafe external link" #6045
- Resolve CodeQL alert 11 "Potentially unsafe external link" #6046
- Resolve CodeQL alert 13 "Potentially unsafe external link" #6047
- Resolve CodeQL alert 14 "Potentially unsafe external link" #6048
- Resolve CodeQL alert 15 "Potentially unsafe external link" #6049
- Resolve CodeQL alert 16 "Potentially unsafe external link" #6050
- Resolve CodeQL alert 17 "Potentially unsafe external link" #6051
- Resolve CodeQL alert 18 "Potentially unsafe external link" #6052
- Resolve CodeQL alert 19 "Potentially unsafe external link" #6053
- Resolve CodeQL alert 20 "Potentially unsafe external link" #6054
- Resolve CodeQL alert 21 and 23 "Potentially unsafe external link" #6230
- Resolve CodeQL alert 22 and 24 "Potentially unsafe external link" #6231
- Resolve CodeQL alert 98 "Potentially unsafe external link" #6309
These address instances which were not flagged by CodeQL:
- Resolve "Potentially unsafe external link" for LA Incubator in
_includes/about-page/about-card-sponsors.html#8823 - Resolve "Potentially unsafe external link" for Carbon Five in
_includes/about-page/about-card-sponsors.html#8824 - Resolve "Potentially unsafe external link" for Sip & Sonder in
_includes/about-page/about-card-sponsors.html#8825 - Resolve "Potentially unsafe external link" in
_includes/current-guides.html#6484
Action Items
- Determine whether to dismiss the alerts or to update the code
- Develop a template for issues that will update the code to resolve the alerts see Epic: Create issues to resolve CodeQL alerts 1- 24, 98 "Potentially unsafe external link" #5129 (comment)
- create sample issue - Resolve CodeQL alert 1 "Potentially unsafe external link" #5673
- For each alert listed above, create an issue using this template
- Once each issue is created, replace the text above with a link to the issue
- Create issues to handle three additional links in includes/about-page/about-card-sponsors.html that use target=_blank that are not flagged by CodeQL. Modify the template as needed.
Activity
github-actions commentedon Aug 2, 2023
[-]Audit/Recommendation for CodeQL query `[QUERY NAME]` and associated alerts ###[/-][+]Audit/Recommendation for CodeQL query `Potentially unsafe external link` and associated alerts[/+]90 remaining items
daras-cu commentedon Oct 4, 2026
@computarisis I unassigned you from your other IM issue as that one was for the design team, you can work on this one instead. There are three more issues that need to be created, under 'These address instances which were not flagged by CodeQL:'.
There is a template linked at the bottom of this issue which you can use as a starting point, but you'll need to edit it a little since there is no actual CodeQL alert associated with the issues you'll be making. The attribute that needs to be added to the links is the same. If you'd like to create one issue first, I can sign off on the format before you proceed with the others. Let me know if you have any questions.
computarisis commentedon Oct 4, 2026
ETA: Mon, Oct 5th by 8PM ET
Availability: Everyday after 8PM ET
_includes/about-page/about-card-sponsors.html#8823_includes/about-page/about-card-sponsors.html#8823castillios commentedon Oct 17, 2026
Hi @computarisis, thanks creating those issues. I reviewed all three and have marked them all as ready for prioritization.
_includes/about-page/about-card-sponsors.html#8823_includes/about-page/about-card-sponsors.html#8824_includes/about-page/about-card-sponsors.html#8825