grpc-benchmark: Worker and server implementation#2706
Open
arjan-bal wants to merge 9 commits into
Open
Conversation
arjan-bal
force-pushed
the
grpc-benchmark-server
branch
from
923b430 to
b9bce39
Compare
ejona86
reviewed
Jun 29, 2026
ejona86
left a comment
ejona86
left a comment
Member
There was a problem hiding this comment.
Didn't get all the way through; sending what I have.
arjan-bal
force-pushed
the
grpc-benchmark-server
branch
2 times, most recently
from
38faf3f to
821047d
Compare
arjan-bal
force-pushed
the
grpc-benchmark-server
branch
from
821047d to
7af7498
Compare
ejona86
approved these changes
Jun 30, 2026
| println!("Server creation requested."); | ||
|
|
||
| if benchmark_server.take().is_some() { | ||
| eprintln!("Server setup received when server already exists, shutting down the existing server"); |
Member
There was a problem hiding this comment.
Does replacing the server actually work? I'd expect start() to fail because the port is already in use. I think we need to set benchmark_server = None here. And that might still be racy.
|
|
||
| let mut server_builder = Server::builder(); | ||
| // Parse security config. | ||
| if let Some(securit_params) = config.security_params { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to: #2666
This PR adds the worker and the benchmarking server implementations. Both components use
tonicandprostfor now, as the gRPC server is still under development. The benchmarking client that uses gRPC will be added in a follow-up PR.