Skip to content

fix(components): return 404 for unknown component libraries #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dgaponov wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(components): return 404 for unknown component libraries #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/pages/components/[libId]/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,21 @@ import {libs} from '../../../content/components';
import {getI18nProps} from '../../../utils';

export const getServerSideProps: GetServerSideProps = async (ctx) => {
const libId = ctx.params?.libId as string;

// Without this check any /components/<anything> renders an empty shell with HTTP 200,
// so unlimited non-existent URLs are indexable as soft 404s. Mirrors the guard in
// src/pages/design/[sectionId]/index.tsx.
const lib = libs.find((item) => item.id === libId);

if (!lib) {
return {
notFound: true,
};
}

return {
props: {libId: ctx.params?.libId, ...(await getI18nProps(ctx))},
props: {libId, ...(await getI18nProps(ctx))},
};
};

Expand Down
Loading