Skip to content

fix(playwright): remove optional peer dependency - #350

Merged
draedful merged 1 commit into
mainfrom
dependencies
Oct 2, 2026
Merged

draedful merged 1 commit into
mainfrom
dependencies

Conversation

@SimbiozizV

@SimbiozizV SimbiozizV commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by Sourcery

Make Playwright a consumer-installed dependency while preserving the package’s React peer dependency requirements.

Bug Fixes:

  • Remove the optional @playwright/test peer dependency from the package metadata.

Documentation:

  • Document the requirement for consumers of the Playwright entry point to install @playwright/test 1.58.0 or later separately.

@sourcery-ai

sourcery-ai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR removes the optional @playwright/test peer dependency from the package manifest and clarifies that consumers using the Playwright API must install @playwright/test 1.58.0 or later themselves, with the lockfile updated accordingly.

File-Level Changes

Change Details Files
Make Playwright a required separately installed test dependency instead of an optional peer dependency.
  • Remove the @playwright/test peer dependency declaration and its optional-peer metadata.
  • Document the minimum supported Playwright version and separate installation requirement for consumers of the Playwright entry point.
  • Update the lockfile to reflect the package metadata change.
package.json
package-lock.json
docs/testing/playwright.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@gravity-ui-bot

Copy link
Copy Markdown
Contributor

Preview is ready.

@draedful
draedful merged commit bebd638 into main Oct 2, 2026
7 checks passed
@gravity-ui gravity-ui Bot mentioned this pull request Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants