graph, node: Warn when running a debug build#6488
Open
dimitrovmaksim wants to merge 1 commit intographprotocol:masterfrom
Open
graph, node: Warn when running a debug build#6488dimitrovmaksim wants to merge 1 commit intographprotocol:masterfrom
dimitrovmaksim wants to merge 1 commit intographprotocol:masterfrom
Conversation
Prefix every log line with [DEBUG-BUILD] and emit a startup warning when graph-node is compiled without --release, so operators are not silently running a degraded build in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6206
Reasoning:
Users building from source may accidentally build graph-node without
--releaseflag and get a severely degraded performanceSolution:
cargo build --release.