csrf: treat Secure(false) as plaintext for Origin checks - #212
Open
team-humaki wants to merge 1 commit into
Open
team-humaki wants to merge 1 commit into
team-humaki wants to merge 1 commit into
Conversation
Local HTTP Origin was compared against a rewritten https request URL, so csrf.Secure(false) still 403'd localhost POSTs. Issue gorilla#190.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190
csrf.Secure(false)is the documented local-dev flag, but Origin checks still rewrote the request URL to https unless the caller also wrapped the request inPlaintextHTTPRequest. POSTs fromhttp://localhost:...then failed same-origin.Secure(false) now sets the plaintext path.
PlaintextHTTPRequeststill works when Secure stays true behind a cleartext proxy.