Skip to content

fix: use io.ReadFull(rand.Reader, b) in generateRandomBytes #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aoright wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use io.ReadFull(rand.Reader, b) in generateRandomBytes #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"encoding/base64"
"fmt"
"html/template"
"io"
"net/http"
"net/url"
)
Expand Down Expand Up @@ -142,14 +143,13 @@ func (cs *csrf) requestToken(r *http.Request) ([]byte, error) {
// fails to function correctly.
func generateRandomBytes(n int) ([]byte, error) {
b := make([]byte, n)
_, err := rand.Read(b)
_, err := io.ReadFull(rand.Reader, b)
// err == nil only if len(b) == n
if err != nil {
return nil, err
}

return b, nil

}

// sameOrigin returns true if URLs a and b share the same origin. The same
Expand Down
Loading