Skip to content

fix(gapic-generator): remove lagging 3.9 refs#16924

Draft
chalmerlowe wants to merge 4 commits intomainfrom
fix/remove-3.9-refs
Draft

fix(gapic-generator): remove lagging 3.9 refs#16924
chalmerlowe wants to merge 4 commits intomainfrom
fix/remove-3.9-refs

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe commented May 4, 2026

Note

This PR is in a holding pattern. It will be merged once we have removed the references to 3.9 in the repo (via generation of the GAPIC libraries and via updates to the handwritten libs)

Removes two lagging refs to 3.9 to finalize the migration of the gapic generator codebase to 3.10+ runtime dependencies.

Fixes #internal issue 🦕

This removes the temporary skip for Python 3.9 in the unit test session and removes it from ALL_PYTHON, completing the drop of Python 3.9 support.
This removes the case for Python 3.9 in the unit test section, as we no longer run tests for this version.
@chalmerlowe chalmerlowe changed the title Fix/remove 3.9 refs fix(gapic-generator): remove lagging 3.9 refs May 4, 2026
@chalmerlowe chalmerlowe added this to the Drop support for 3.7-3.9 milestone May 4, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes support for Python 3.9 from the CI configuration and the gapic-generator noxfile. Feedback indicates that the dispatch logic in the CI script is missing entries for other supported Python versions (3.11 and 3.12), which could lead to incomplete test coverage. Additionally, it is noted that dropping support for a Python version constitutes a breaking change that should be reflected in the versioning strategy.

Comment thread ci/run_single_test.sh Outdated
Comment thread ci/run_single_test.sh Outdated
This removes Python 3.9 from the unittest matrix in unittest.yml.
@chalmerlowe chalmerlowe self-assigned this May 4, 2026
@chalmerlowe chalmerlowe added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant