Skip to content

test(bigframes): Add BIGFRAMES_TEST_PROJECT override var for nox config#16883

Merged
parthea merged 2 commits intomainfrom
tbergeron_nox_test_project_var
Apr 30, 2026
Merged

test(bigframes): Add BIGFRAMES_TEST_PROJECT override var for nox config#16883
parthea merged 2 commits intomainfrom
tbergeron_nox_test_project_var

Conversation

@TrevorBergeron
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to override the Google Cloud Project ID used in Nox sessions by setting the BIGFRAMES_TEST_PROJECT environment variable. It updates various test, notebook, and benchmark sessions to propagate this override via the GOOGLE_CLOUD_PROJECT environment variable. I have no feedback to provide.

@TrevorBergeron TrevorBergeron requested a review from tswast April 30, 2026 00:43
@TrevorBergeron TrevorBergeron marked this pull request as ready for review April 30, 2026 00:43
@TrevorBergeron TrevorBergeron requested review from a team as code owners April 30, 2026 00:43
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@parthea parthea merged commit a375896 into main Apr 30, 2026
30 checks passed
@parthea parthea deleted the tbergeron_nox_test_project_var branch April 30, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants