impl(oauth2): use impersonated email for RAB with external accounts#16139
impl(oauth2): use impersonated email for RAB with external accounts#16139scotthart wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements support for extracting the service account email from the service_account_impersonation_url in external account credentials, in compliance with AIP-4117. It updates ExternalAccountImpersonationConfig to include an email field, which is then used in AllowedLocationsRequest when regional access boundaries (RAB) are enabled. The changes also replace several instances of absl::optional with std::optional and add corresponding unit and integration tests to verify the new behavior. There are no review comments, and I have no additional feedback to provide.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16139 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 2356 2356
Lines 220557 220594 +37
=======================================
+ Hits 204501 204538 +37
Misses 16056 16056 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Retrieving the RAB token when external credentials impersonate a service account, should use the service account in lieu of the workforce or workload identity information.