docs: private API guidance and formatting fixes#2700
docs: private API guidance and formatting fixes#2700raushan728 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @raushan728, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the clarity and correctness of the project's documentation. It resolves a minor syntax issue in the upgrade guide and introduces essential guidance for developers working with private APIs, ensuring a smoother experience for users of the library. The changes aim to make the documentation more accurate and helpful without altering any core functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves the documentation by fixing some formatting issues, correcting a syntax error in a code example, and adding a helpful note about using private APIs. The changes make the documentation clearer and more accurate. I have one suggestion to improve the clarity of an example in UPGRADING.md to avoid potential user confusion.
ZLeventer
left a comment
There was a problem hiding this comment.
The static_discovery=False tip for private APIs is a useful addition — this trips up developers who have a private/internal API and can't figure out why build() fails with a "service not found" error when the API isn't in the bundled discovery documents.
The rest of the changes (markdown formatting fixes, whitespace normalization, list indentation) are cosmetic but improve readability. The syntax error fix in the original README (trailing whitespace in code blocks) is minor but correct.
One thing: the PR title says "fix syntax error" but the real value-add is the private API documentation section. Might be worth updating the title/description to highlight that — it'll make it easier for maintainers to prioritize.
2184def to
6a362ff
Compare
Thanks for the feedback updated the PR title and desc to highlight the private API guidance as the main change |
static_discovery=Falsetip for private APIs inREADME.md