Skip to content

test: skip echo test on rest - #999

Merged
robertvoinescu-work merged 1 commit into
googleapis:mainfrom
robertvoinescu-work:fix/integrationTests
Aug 28, 2026
Merged

test: skip echo test on rest#999
robertvoinescu-work merged 1 commit into
googleapis:mainfrom
robertvoinescu-work:fix/integrationTests

Conversation

@robertvoinescu-work

@robertvoinescu-work robertvoinescu-work commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

b/553623819

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the EchoCustomError integration test in EchoTest.cs to conditionally skip REST-based tests due to an unresolved issue with custom error details unpacking, while changing the assertion to verify that custom error details are not null for other test types. There are no review comments, so I have no feedback to provide.

@robertvoinescu-work
robertvoinescu-work marked this pull request as ready for review August 27, 2026 21:53
@robertvoinescu-work
robertvoinescu-work requested a review from a team as a code owner August 27, 2026 21:53
@robertvoinescu-work
robertvoinescu-work merged commit a970673 into googleapis:main Aug 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants