Repository navigation
genmedia-for-commerce: video model gemini-omni-1.2-flash - #2871
Merged
Merged
Conversation
lspataroG
requested review from
eliasecchig and
giuliosalierno
as code owners
November 5, 2026 18:12
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated House Rules review — 0 finding(s).
Also, on lines this PR does not change:
core/python/genmedia-for-commerce/genmedia4commerce/core/models.py:43— [MINOR] env read carries a hardcoded default (second argument is a hardcoded default); 1 occurrence(s) across 1 file(s). Defaults belong in .env.example, not in the code (core/python/genmedia-for-commerce/genmedia4commerce/core/models.py:43)
| studio_agent=_env("GENMEDIA_STUDIO_AGENT_MODEL", "gemini-4-argon"), | ||
| image=_env("GENMEDIA_IMAGE_MODEL", "gemini-nano-banana-2.1"), | ||
| video=_env("GENMEDIA_VIDEO_MODEL", "gemini-omni-1.1-flash-preview"), | ||
| video=_env("GENMEDIA_VIDEO_MODEL", "gemini-omni-1.2-flash"), |
Contributor
There was a problem hiding this comment.
[MINOR] It seems this environment read has a hardcoded default. Can we read GENMEDIA_VIDEO_MODEL without a fallback and rely on .env.example instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GENMEDIA_VIDEO_MODEL) is nowgemini-omni-1.2-flash, wasgemini-omni-1.1-flash-preview. Used by 360° Spin and Video Try-On; same API revision.config.env.example,.env.exampleand the model test follow.Testing
pytest tests -m "not live": 2393 passed.