docs: Demonstration of Google Firestore for Persistent session data … by mohan-ganesh · Pull Request #2818 · google/adk-recipes

mohan-ganesh · 2026-10-18T20:41:42Z

docs: Demonstration of Google Firestore for Persistent session data

Add agent demonstrating session persistence using Google Cloud Firestore

This commit introduces a new sample agent, FirestoreRunner, that shows how to use FirestoreDatabaseRunner to persist agent session state. It includes a simple time-telling agent and a corresponding test class

Submitting new PR @happyhuman as per #772

github-actions

Automated House Rules review — 2 finding(s).

github-actions

Automated Security review — 2 finding(s).

Round 1 · 0 of this PR's 25 automated comments used · this round is capped at 20 across all reviewers.

github-actions · 2026-10-19T02:00:49Z

Ready for review. All checks pass.

Re-requested review from tommywagz.

…r Persistent session data store

happyhuman

Just reviewed the PR and left a few comments. PTAL

happyhuman · 2026-10-29T21:06:47Z

+language: "java" # Options: [python | java | go | kotlin | typescript]
+description: "Demonstrates persistent multi-turn conversation using Google Firestore as a session data store with the ADK Java SDK."
+
+deployable: true


The .github/policy.yml entry in this PR notes FirestoreRunner is an interactive stdin CLI rather than a service. Should deployable be false here?

This issue was flagged from my prior run..

Looking at tools/validate_manifest.py — every recipe under contrib/ is required to have deployable: true unconditionally, so it needs to stay. The .github/policy.yml exemption I added is answering a different question: it only skips the recipe-docker-build HTTP-probe step for this recipe, since FirestoreRunner is a stdin CLI and never binds a port — the image still gets built. Added a comment on the deployable: true line in the manifest clarifying this so it doesn't look contradictory again.

mohan-ganesh · 2026-10-31T17:58:51Z

thanks for review Shahin @happyhuman. I have addressed all except the manifest.yml.. that seem to have dependancy on the contrib/ is required to have deployable: true unconditionally.. please take a look.

happyhuman

Just reviewed the PR and left a few comments. PTAL

happyhuman · 2026-11-03T21:02:52Z

+                                .toMaybe()
+                            : Maybe.error(error))
+                .blockingGet();
+        logger.info("Resumed session " + sessionId + " for user " + userId);


It seems this still logs "Resumed session" when the SessionNotFoundException fallback above created a brand-new session instead. Is that intentional?

This was intentional. If the user passes an user id and session id, if found use, else create the session using the provided values for demonstration.

happyhuman · 2026-11-03T21:02:52Z

+    logger.info("FirestoreRunner finished execution.");
+    // The Gemini API client leaves non-daemon OkHttp threads running; force
+    // a clean exit instead of waiting on them to time out.
+    System.exit(0);


still exits 0 after the catch above

The System.exit(0) isn't there to handle the exception from the catch block above — it's there regardless of whether an exception occurs. The catch only logs errors from the chat loop; it doesn't change the JVM's thread state.

The real issue is that the Gemini API client (via OkHttp) spins up non-daemon threads internally. Those threads keep running even after main() returns normally, which means the JVM won't exit on its own — the process just hangs. System.exit(0) forces termination so the process doesn't get stuck waiting on threads we don't manage.

So this isn't error-path cleanup; it's unconditional shutdown needed because of a dependency's threading behavior, placed after the try-catch so it runs whether we exit via quit, EOF, or a caught exception.

mohan-ganesh · 2026-11-03T21:17:10Z

@happyhuman updated the comments to two new query.

happyhuman

Just reviewed the PR and left a few comments. PTAL

- Comment out GOOGLE_API_KEY in .env.example for default Vertex AI path - Document env export step in README for Java runtime - Preserve stack trace on error in FirestoreRunner - Remove redundant resources COPY in Dockerfile - Add Apache-2.0 license header to logback.xml

mohan-ganesh · 2026-11-07T23:33:07Z

@happyhuman addressed the latest review comments.. please review them.

…el to gemini-3.7-flash, and add docker docs - Update default model from gemini-3.5-flash to gemini-3.7-flash - Add .dockerignore to exclude target, .env, and metadata from build context - Add Apache-2.0 license header to adk-firestore.properties - Document interactive Docker CLI usage in README

mohan-ganesh requested a review from tommywagz as a code owner October 18, 2026 20:41

github-actions Bot reviewed Oct 18, 2026

View reviewed changes

Comment thread contrib/java/firestore-session-service/README.md Resolved

Comment thread ...service/src/test/java/com/google/adk/samples/agents/firestorerunner/FirestoreRunnerTest.java Resolved

github-actions Bot reviewed Oct 18, 2026

View reviewed changes

Comment thread contrib/java/firestore-session-service/src/main/resources/adk-firestore.properties Resolved

Comment thread ...ion-service/src/main/java/com/google/adk/samples/agents/firestorerunner/FirestoreRunner.java Resolved

mohan-ganesh force-pushed the firestore-session-servicev1 branch 3 times, most recently from d2891b1 to bc61289 Compare October 18, 2026 20:51

github-actions Bot added the status/not-ready-for-review Review requests held until checks pass and bot comments are resolved label Oct 19, 2026

mohan-ganesh force-pushed the firestore-session-servicev1 branch from bc61289 to e870529 Compare October 19, 2026 22:05

github-actions Bot removed the status/not-ready-for-review Review requests held until checks pass and bot comments are resolved label Oct 19, 2026

github-actions Bot added the status/not-ready-for-review Review requests held until checks pass and bot comments are resolved label Oct 28, 2026

git push --force-with-leasedocs: Demonstration of Google Firestore fo…

12893ca

…r Persistent session data store

mohan-ganesh force-pushed the firestore-session-servicev1 branch from b189f71 to 12893ca Compare October 28, 2026 21:47

mohan-ganesh requested a review from happyhuman as a code owner October 28, 2026 21:47

github-actions Bot removed the status/not-ready-for-review Review requests held until checks pass and bot comments are resolved label Oct 28, 2026

Merge branch 'google:main' into firestore-session-servicev1

ab16d63

happyhuman reviewed Oct 29, 2026

View reviewed changes

Merge branch 'google:main' into firestore-session-servicev1

56511b3

github-actions Bot added the status/not-ready-for-review Review requests held until checks pass and bot comments are resolved label Oct 31, 2026

Addressed the review comments

7a4f290

mohan-ganesh force-pushed the firestore-session-servicev1 branch from 4c2b737 to 7a4f290 Compare October 31, 2026 17:49

Merge branch 'main' into firestore-session-servicev1

0624cfb

mohan-ganesh requested a review from happyhuman October 31, 2026 17:53

github-actions Bot removed the status/not-ready-for-review Review requests held until checks pass and bot comments are resolved label Oct 31, 2026

happyhuman reviewed Nov 3, 2026

View reviewed changes

mohan-ganesh requested a review from happyhuman November 4, 2026 12:59

Merge branch 'main' into firestore-session-servicev1

d8efc0e

happyhuman reviewed Nov 4, 2026

View reviewed changes

mohan-ganesh and others added 2 commits November 7, 2026 18:25

Merge branch 'google:main' into firestore-session-servicev1

9406980

mohan-ganesh requested a review from happyhuman November 7, 2026 23:33

Conversation

mohan-ganesh commented Oct 18, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

happyhuman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

happyhuman Oct 29, 2026

Choose a reason for hiding this comment

Uh oh!

mohan-ganesh Oct 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mohan-ganesh commented Oct 31, 2026

Uh oh!

happyhuman left a comment

Choose a reason for hiding this comment

Uh oh!

happyhuman Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

mohan-ganesh Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

happyhuman Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

mohan-ganesh Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

mohan-ganesh commented Nov 3, 2026

Uh oh!

happyhuman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mohan-ganesh commented Nov 7, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Oct 19, 2026 •

edited

Loading