fix(models): standardize Anthropic API error handling in AnthropicLlm#5511
Open
sebastienc wants to merge 1 commit intogoogle:mainfrom
Open
fix(models): standardize Anthropic API error handling in AnthropicLlm#5511sebastienc wants to merge 1 commit intogoogle:mainfrom
sebastienc wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5396
Disclaimer: I'm using Claude Code to generate the following text. I find the summary is better than what I would've wrote.
Standardizes how
AnthropicLlmhandles errors from the Anthropic API, bringing it in line with the error handling pattern used elsewhere in ADK.AnthropicRateLimitError— new exception class (subclassesException, notanthropic.RateLimitError) raised when the API returns a 429; includes a helpful mitigation message pointing users toward rate limit remediation options; original error is chained viafrom eso the full traceback is preservedgenerate_content_async— wraps the non-streamingmessages.createcall in atry/except anthropic.RateLimitErrorblock and re-raises asAnthropicRateLimitError_generate_content_streaming— same wrapping around the streamingmessages.createcall; all otheranthropicexceptions propagate unchangedTesting plan
4 new tests added to
tests/unittests/models/test_anthropic_llm.py. Full suite: 63 passed.