Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I have signed the Google Individual CLA under dev.sai5880@gmail.com. Please recheck. |
Author
|
CLA check is now green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops the CBCM PowerShell samples from writing the raw OAuth access token to the plaintext log file next to the script. The token is still acquired and used exactly as before; only the log message changed.
Changes
Windows/PowerShell/cbcm/UnenrollBrowser.ps1: logOAuth token acquired.instead of the token value.Windows/PowerShell/cbcm/MoveEnrolledBrowserByWindowsOSName.ps1: logOAuth token acquired.instead of the token value.Windows/PowerShell/cbcm/cbcm_get_token_with_json_file.ps1: logOAuth token acquired.instead of the token value.Token acquisition, scopes, and API calls are unchanged. The rest of the log format and the
Copy-WriteToLoghelper are unchanged.Validation
git diff --checkreports no whitespace errors.The token is, token interpolation inside-logString, andBearerinside-logString: no matches remain.Copy-WriteToLogcall in the three scripts. The remaining log messages cover NuGet version, device ID, response text, exception messages, and registry token deletion status (no token values).Fixes
Fixes #83