Skip to content

http/httpproxy: ignore DNS root dots in NO_PROXY matching - #283

Open
anandt1201 wants to merge 1 commit into
golang:masterfrom
anandt1201:fix-79944-root-dot-normalization
Open

anandt1201 wants to merge 1 commit into
golang:masterfrom
anandt1201:fix-79944-root-dot-normalization

Conversation

@anandt1201

Copy link
Copy Markdown

NO_PROXY treats a fully qualified DNS name with a terminal root dot as
different from the same domain without the dot. Ignore that dot in both
request hosts and configured domain matchers, preserving subdomain-only
and port-specific rules. Ignore root-only entries after normalization.

Cover terminal dots on either side, subdomains, wildcards, ports,
case-insensitive matching, and unrelated domains.

Fixes golang/go#79944

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 5df16a0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/865426.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/net/http/httpproxy: NO_PROXY does not normalize hosts with trailing dot

2 participants