Skip to content

http2: return flow control for response data of a canceled request - #278

Open
cristiangirlea wants to merge 1 commit into
golang:masterfrom
cristiangirlea:fix-http2-cancel-flow-control
Open

cristiangirlea wants to merge 1 commit into
golang:masterfrom
cristiangirlea:fix-http2-cancel-flow-control

Conversation

@cristiangirlea

Copy link
Copy Markdown

When a request is canceled while RoundTrip waits for the response
headers, its stream stays registered until the request's cleanup
forgets it. Response data arriving in between is charged to the
connection window and buffered for a body nobody will read, and nothing
returns it. Each canceled request that races with its response leaks
the data it received, until the window is used up and every response
on the connection stalls after its headers.

Discard the buffered data and return its flow control when RoundTrip
gives up on a stream, as closing an unread response body does, and stop
buffering data that arrives afterwards so that it is returned on
receipt. The refund now happens once per stream, so closing a response
body twice no longer returns its unread data twice.

This is the backport of the equivalent fix in std.

For golang/go#82677

When a request is canceled while RoundTrip waits for the response
headers, its stream stays registered until the request's cleanup
forgets it. Response data arriving in between is charged to the
connection window and buffered for a body nobody will read, and nothing
returns it. Each canceled request that races with its response leaks
the data it received, until the window is used up and every response
on the connection stalls after its headers.

Discard the buffered data and return its flow control when RoundTrip
gives up on a stream, as closing an unread response body does, and stop
buffering data that arrives afterwards so that it is returned on
receipt. The refund now happens once per stream, so closing a response
body twice no longer returns its unread data twice.

This is the backport of the equivalent fix in std.

For golang/go#82677
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: c930f47) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/862422.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@cristiangirlea
cristiangirlea marked this pull request as ready for review November 20, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants