Skip to content

publicsuffix: keep the prevailing icann value past parent-only nodes - #277

Open
hcrosse wants to merge 1 commit into
golang:masterfrom
hcrosse:publicsuffix-icann-parent-only
Open

hcrosse wants to merge 1 commit into
golang:masterfrom
hcrosse:publicsuffix-icann-parent-only

Conversation

@hcrosse

@hcrosse hcrosse commented Nov 3, 2026 •

Copy link
Copy Markdown

PublicSuffix set icann at every node it visited without a wildcard,
including parent-only nodes, which hold no rule and exist only because
deeper rules hang below them. The generator gives those nodes icann
true, so a domain that passed one under a private rule reported its
private suffix as ICANN managed.

For example, for "foo.dualstack.us-east-1.amazonaws.com", PublicSuffix
returned ("us-east-1.amazonaws.com", true), while slowPublicSuffix
returns false.

Update icann only at nodes that hold a rule, or at a parent-only node
while no rule has matched yet. The latter keeps the result for domains
such as "za" (see golang/go#22959).

Fixes golang/go#82833

@hcrosse
hcrosse force-pushed the publicsuffix-icann-parent-only branch 2 times, most recently from e804d4b to b7ff67c Compare November 3, 2026 18:51
PublicSuffix set icann at every node it visited without a wildcard,
including parent-only nodes, which hold no rule and exist only because
deeper rules hang below them. The generator gives those nodes icann
true, so a domain that passed one under a private rule reported its
private suffix as ICANN managed.

For example, for "foo.dualstack.us-east-1.amazonaws.com", PublicSuffix
returned ("us-east-1.amazonaws.com", true), while slowPublicSuffix
returns false.

Update icann only at nodes that hold a rule, or at a parent-only node
while no rule has matched yet. The latter keeps the result for domains
such as "za" (see golang/go#22959).

Fixes golang/go#82833
@hcrosse
hcrosse force-pushed the publicsuffix-icann-parent-only branch from b7ff67c to 721520d Compare November 3, 2026 19:10
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 721520d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/858521.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/858521.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/net/publicsuffix: PublicSuffix reports a private suffix as ICANN after traversing a node without a rule

2 participants