Repository navigation
Conversation
e804d4b to
b7ff67c
Compare
PublicSuffix set icann at every node it visited without a wildcard,
including parent-only nodes, which hold no rule and exist only because
deeper rules hang below them. The generator gives those nodes icann
true, so a domain that passed one under a private rule reported its
private suffix as ICANN managed.
For example, for "foo.dualstack.us-east-1.amazonaws.com", PublicSuffix
returned ("us-east-1.amazonaws.com", true), while slowPublicSuffix
returns false.
Update icann only at nodes that hold a rule, or at a parent-only node
while no rule has matched yet. The latter keeps the result for domains
such as "za" (see golang/go#22959).
Fixes golang/go#82833
b7ff67c to
721520d
Compare
|
This PR (HEAD: 721520d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/858521. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/858521. |
PublicSuffix set icann at every node it visited without a wildcard,
including parent-only nodes, which hold no rule and exist only because
deeper rules hang below them. The generator gives those nodes icann
true, so a domain that passed one under a private rule reported its
private suffix as ICANN managed.
For example, for "foo.dualstack.us-east-1.amazonaws.com", PublicSuffix
returned ("us-east-1.amazonaws.com", true), while slowPublicSuffix
returns false.
Update icann only at nodes that hold a rule, or at a parent-only node
while no rule has matched yet. The latter keeps the result for domains
such as "za" (see golang/go#22959).
Fixes golang/go#82833