Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the
testingplugin’s example management and build process, updates generated code to reflect newer tool versions, and introduces better linting and exclusion practices. The changes make it easier to generate, build, and test example services, and ensure that generated files and linting processes are up-to-date and accurate.Build and Example Management Improvements:
testing/Makefileto add explicitgen,example,test,build-examples, andcleantargets for generating, building, and testing example services (calculator,httpgrpc,jsonrpc). This replaces the old, less flexible approach and provides clearer, more maintainable commands..golint_excludefile to exclude theexamplesdirectory from linting, preventing unnecessary lint errors on example code.Linting and Formatting Enhancements:
linttarget inplugins.mkis updated to exclude.pb.gofiles (protobuf-generated code) from formatting checks, avoiding false positives and unnecessary formatting errors.Generated Code Updates:
testing/examples/calculator/genand related subdirectories now show updated headers, reflecting the latest version ofgoaand the new command-line arguments used for code generation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]goa.jsonfile is added to record thegoaversion used for code generation, supporting better reproducibility.Minor Documentation and Code Quality:
These changes collectively improve the maintainability, reliability, and developer experience when working with the
testingplugin and its example services.