fix: recursively convert slices of structs when decoding to map - #211
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
When decoding a struct to a map with deep mapping enabled (via the deep tag option or DecoderConfig.Deep), slices whose elements are pointers to structs (such as []*MyStruct) were not being converted to []map[string]any. In decodeMapFromStruct, v.Type().Elem().Kind() returned reflect.Ptr, causing childType to fall back to the pointer type rather than map[string]any. Dereference pointer types on the slice element type when determining childType so that both slices of structs and slices of pointers to structs are recursively converted to maps. Fixes go-viper#120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When decoding a struct to a map with deep mapping enabled (either via the
deeptag option orDecoderConfig.Deep), fields that are slices of pointers to structs (such as[]*MyStruct) were not being converted to[]map[string]any. Instead, the original[]*MyStructtype was retained in the target map.Root Cause
In
decodeMapFromStruct,v.Type().Elem().Kind()was checked directly without dereferencing pointer types:For slices of struct pointers,
v.Type().Elem().Kind()isreflect.Ptr, which fell through to the default branch and preserved the pointer type rather than selectingmap[string]any.Solution
Dereference pointer indirection on
v.Type().Elem()when determiningchildTypeso that both direct structs and struct pointer elements are handled recursively.Testing
Added
TestDecode_structPtrArrayDeepMapinmapstructure_test.goverifying conversion of[]*SourceChildand*[]*SourceChildto[]map[string]anyvia:deepstruct tag optionDecoderConfig.Deep = trueFixes #120