fix: restore escaped brace command args#2818
Open
cyphercodes wants to merge 1 commit intogo-task:mainfrom
Open
fix: restore escaped brace command args#2818cyphercodes wants to merge 1 commit intogo-task:mainfrom
cyphercodes wants to merge 1 commit intogo-task:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mvdan.cc/sh/v3back tov3.13.0to restore shell-compatible handling of escaped braces in command arguments.\{\{iriname\}\}being passed to the command as literal{{iriname}}.Fixes #2812
Testing
go test ./internal/execext -count=1go test ./... -run TestRunCommandEscapedBraces -count=1go test ./... -count=1Manual Taskfile repro with
go run ./cmd/task --dir /tmp/oss-pr-pipeline/repro-2812 exportI have read and followed the Contribution Guide