Feature/pull interface#63
Open
denyost wants to merge 203 commits into
Open
Conversation
…com/gnmic/operator into feature/pull-interface
…ic/operator into feature/pull-interface
…ic/operator into feature/limit-target-loading
…com/gnmic/operator into feature/limit-target-loading
…ic/operator into feature/pull-interface
…ic/operator into feature/pull-interface
…lecting nextField
Collaborator
Author
|
@karimra |
denyost
commented
Jun 1, 2026
| if selector.Key == "" { | ||
| return "", fmt.Errorf("secret key selector has empty key for secret %s/%s", namespace, selector.Name) | ||
| } | ||
| val, ok := secret.Data[selector.Key] |
Collaborator
Author
There was a problem hiding this comment.
@karimra Regarding to the discussion we had on this. stringData and data are internally merged into the data field. See Constraints on Secret names and data.
This means Secrets should always be read from secret.Data. The values in secret.Data are already decoded, so they can be used directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a generic http pull interfaces