Skip to content

fix: Updated the Arduino pins to match the Instructables description. - #6

Closed
hummelstrand wants to merge 16 commits into
glyons:mainfrom
hummelstrand:main
Closed

hummelstrand wants to merge 16 commits into
glyons:mainfrom
hummelstrand:main

Conversation

@hummelstrand

Copy link
Copy Markdown
Contributor

The schematic on top of https://www.instructables.com/Build-the-Ultimate-Darkroom-Timer/ doesn't match the pin connections in the code unless you change line 12-15 in darkroom_timer.io.
This took me a while to problem-solve and figure out, so it would be nice if this was fixed.

Added beep every second of the stopwatch when the focus light is turned on.
Made the interval between each strip configurable in a variable so that the user can more easily change it.
Made the Caqncel button work to turn off the Focus Light.
Fixed typo in comment.
…to a fixed value. Preliminary work for when the brightness button will be used for another function.
… to reflect that they are now used for setting base exposure f-stops.

Updated the copilot instructions to reflect this.
…trip function might be writing bad values causing errors that can only be fixed by erasing the EEPROM and starting over.
@glyons glyons closed this Jan 26, 2026
@glyons glyons reopened this Jan 26, 2026

@glyons glyons left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change

@glyons glyons left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one not too happy about

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look a good idea

@hummelstrand

Copy link
Copy Markdown
Contributor Author

Hi, sorry for this, I only intended for my pull request to address the pinout. I've been playing around with new functionality in my own repo, I did not intend for my playground commits to be merged upstream, at least not until they are done and tested. Let me review how all these newer commits have been incorporated into the original PR.

@hummelstrand

Copy link
Copy Markdown
Contributor Author

I'll close this PR and create a new one with just the intended changes. Sorry about this.

@hummelstrand
hummelstrand deleted the main branch January 27, 2026 21:12
@hummelstrand
hummelstrand restored the main branch January 27, 2026 21:14
@hummelstrand
hummelstrand deleted the main branch January 27, 2026 21:15
@glyons

glyons commented Jan 28, 2026

Copy link
Copy Markdown
Owner

I cherrypicked the TM library and add that into the main branch. Coincidently the auther of TM1638plus is another person with the exact same name as I. (I mean what are the odds!) Anyway please do submit your changes once your happy with them. Thanks again, Gavin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants