Repository navigation
gh-1264: Reuse nox environments to speed up linting workflow - #1265
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The workflow and session changes are focused, with no unresolved blocking findings.
0 open findings
What changed in this PR
Speeds up GLASS automation by reducing dependency synchronization and caching linting environments.
Changes:
- Adds prek caching and uses
uv run --no-syncacross workflows. - Makes Nox session Python versions explicit.
- Narrows the documented contributor dependency installation.
| File | Description |
|---|---|
| noxfile.py | Defines explicit Python versions for sessions. |
| CONTRIBUTING.md | Updates dependency installation guidance. |
| .github/workflows/test.yaml | Skips synchronization and updates backend-test session selection. |
| .github/workflows/run-examples.yaml | Skips synchronization when running examples. |
| .github/workflows/regression-test.yaml | Skips synchronization for regression tests. |
| .github/workflows/linting.yaml | Caches prek environments and enables verbose output. |
| .github/workflows/documentation.yaml | Skips synchronization when building documentation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
connoraird
reviewed
Oct 16, 2026
connoraird
approved these changes
Oct 16, 2026
Member
Author
|
@connoraird I've pushed 862d4b3 to fix linting on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed when doing #1254 that we were getting very slow in the linting workflow. This PR splits up some of the work.
--no-syncwe make sure we actually reuse the environmentsnoxfile.pyis now behaving as it should have been* Removedbenchmarksfrom type checkingLinting has gone from timing out, to 7 minutes, to less than a minute.
Closes: #1264
Checks