Repository navigation
gh-1152: Test any xp with cosmo fixture - #1257
Merged
Merged
Conversation
paddyroddy
reviewed
Oct 15, 2026
| emulates the potential setup of the user who may use a Cosmology | ||
| library which is not array api compatible. | ||
| """ | ||
| return MockCosmology(np) |
Member
There was a problem hiding this comment.
Let me extract the fixture bit from #1232 first, so we can be consistent
Contributor
Author
There was a problem hiding this comment.
Will we be able to merge #1232 before we finish?
connoraird
force-pushed
the
connor/test-all-xp-with-cosmo
branch
from
October 15, 2026 15:47
d4333ae to
ccde4a9
Compare
paddyroddy
approved these changes
Oct 15, 2026
Comment on lines
57
to
-44
| library which is not array api compatible. | ||
|
|
Member
There was a problem hiding this comment.
This blank lines looks weird but it has been the format we have been using. Should in theory always be there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
xpwith the existingcosmofixture.Refs: #1152
Checks