fix(bash): sed replacement escaping, BSD portability, dead cleanup in update-agent-context.sh

[404prefrontalcortexnotfound]

Summary

Three bugs in scripts/bash/update-agent-context.sh that cause silent failures on macOS and potential data corruption with special characters in project/technology names.

Bug 1: sed escaping targets wrong side (lines 318-320)

The escaping function escapes regex pattern characters ([, ., *, ^, $, +, {, }, |) but these variables are used as sed replacement strings, not patterns. In sed replacements, only two characters are special:

• & — inserts the entire matched pattern
• \ — escape character

Impact: A technology name containing & (e.g., "AT&T", "R&D") silently corrupts the agent context file. The & gets replaced with the entire matched text from the left side of the substitution.

Fix: Escape only & and \ in replacement strings. Also adds escaping for project_name which was used unescaped.

Bug 2: BSD sed newline insertion fails on macOS (lines 364-366)

# Current — fails silently on BSD sed (macOS)
newline=$(printf '\n')
sed -i.bak2 "s/\\\\n/${newline}/g" "$temp_file"

BSD sed does not support literal newlines in replacement strings via variable expansion. GNU sed (Linux) does. This means the \n → newline conversion silently fails on macOS, leaving literal \n sequences in the generated agent context files.

Fix: Replace with portable awk approach:

awk '{gsub(/\\n/,"\n")}1' "$temp_file" > "$temp_file.tmp" && mv "$temp_file.tmp" "$temp_file"

Bug 3: cleanup() removes non-existent files (lines 125-126)

rm -f /tmp/agent_update_*_$$
rm -f /tmp/manual_additions_$$

The script never creates files matching these patterns — all temp files use mktemp with random suffixes. The wildcard with $$ (PID) in /tmp is a code smell that could theoretically match unrelated files.

Fix: Remove the dead rm commands. Temp files from mktemp are cleaned up inline after use.

Testing

• bash -n syntax check passes
• Tested on macOS 15 (Darwin, BSD sed) — all three fixes verified

Related Issues

Fixes #154 — update-agent-context.sh seems to be failing on macOS
Fixes #293 — update-agent-context.sh script fails with sed expression errors
Related: #338 — Problems detected by shellcheck on the provided bash scripts

[Copilot]

Pull request overview

This PR updates scripts/bash/update-agent-context.sh to be safer and more portable across GNU/BSD toolchains (notably macOS), focusing on correct escaping for sed replacements, portable newline handling, and safer temp-file cleanup.

Changes:

• Fixes sed replacement escaping to prevent corruption when values contain replacement-special characters (notably & and \), and applies escaping to additional substituted values (e.g., project_name).
• Replaces BSD-incompatible sed newline insertion with a portable awk-based \n → newline conversion.
• Reworks cleanup to track and remove only known temp files; also adjusts agent support/path mappings (notably Copilot path and Forge handling).

Show a summary per file

File	Description
scripts/bash/update-agent-context.sh	Improves sed replacement safety, macOS portability, and temp-file cleanup; updates agent path/support mappings.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 2

[Copilot]

COPILOT_FILE was changed to .github/agents/copilot-instructions.md, but the Copilot integration and tests in this repo still define the context file as .github/copilot-instructions.md (see src/specify_cli/integrations/copilot/__init__.py and tests/integrations/test_integration_copilot.py). As-is, running this script will generate/update a different file than the rest of the codebase expects. Consider reverting this path change (keep context in .github/), or update the integration’s context_file + docs/tests in the same PR so the repo stays consistent.

Suggested change

	COPILOT_FILE="$REPO_ROOT/.github/agents/copilot-instructions.md"
	COPILOT_FILE="$REPO_ROOT/.github/copilot-instructions.md"

[Copilot]

The forge agent type support was removed (case item deleted and help text updated). However, this repo still has a Forge integration (src/specify_cli/integrations/forge/__init__.py has key = "forge" and context_file = "AGENTS.md"), and AGENTS.md documents Forge-specific behavior. If Forge is still a supported agent, consider keeping a forge) case that maps to AGENTS.md (similar to opencode/codex) or update the related integration/docs in the same PR to avoid breaking ./update-agent-context.sh forge.

[mnriem]

Please address Copilot feedback. You might have to pull in upstream/main