Repository navigation
Conversation
loadDefaultFiles loads the legacy `config` first and `config.ghostty` second. Config.zig also documents that `config-file` includes take effect after the entire configuration is loaded, not at the end of the current file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@meop is attempting to deploy a commit to the Ghostty Team on Vercel. A member of the Team first needs to authorize it. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
meop
force-pushed
the
docs/config-load-order
branch
from
November 5, 2026 21:22
f182ea0 to
479b324
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two spots in the config docs don't match
src/config/Config.zig, from ghostty-org/ghostty#14828:config.ghosttybeforeconfig, soconfigwould win.loadDefaultFilesloadsconfigfirst and thenconfig.ghostty, and its doc comment says the same. This swaps both lists.config-filetiming. The docs say includes are processed at the end of the current file. Theconfig-filedoc comment says they "do not take effect until after the entire configuration is loaded", andConfig.loadcallsloadRecursiveFilesafter the default files and CLI args. This changes that sentence, and says CLI flags are part of what loads first, so a key in an included file overrides the same CLI flag.npm run lintandnpm run buildpass, run on a GitHub runner in my fork. I used Claude Code to read the source and make the edit.🤖 Generated with Claude Code