Skip to content

chore(lint): Remove Biome from Toolkit - #1426

Merged
BYK merged 5 commits into
mainfrom
chore/remove-biome
Oct 6, 2026
Merged

BYK merged 5 commits into
mainfrom
chore/remove-biome

Conversation

@BYK

@BYK BYK commented Oct 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove Biome and Ultracite from the CLI manifest, lockfile, hooks, editor settings, and contributor guidance.
  • Use Oxlint and Oxfmt for CLI files while preserving command-output, database, import, and silent-catch policies in a tested CLI lint plugin.
  • Convert CLI suppressions and reformat CLI source and tests. The large file count is primarily formatter changes; historical changelog entries remain intact.

Validation

  • Root build/typecheck and lint passed. CLI package policy, generated-file checks, and documentation links passed.
  • CLI unit suite: 10,470 passed, 16 skipped. MCP-core: 1,753 passed, 6 skipped; MCP-server: 83 passed; MCP test client: 80 passed; Cloudflare: 433 passed. Root script tests: 64 passed.
  • After incorporating main's issue-unlink change: 159 focused issue-link tests, typecheck, lint, generated-file/policy checks, and root script tests passed.
  • The combined root test command reached its 15-minute limit after the CLI suite; remaining package suites passed separately.

Review notes

  • Oxlint's five standard plugins remain enabled; the CLI plugin adds 13 targeted rules and unused-disable reporting. Formatter changes are confined to CLI files.
  • No production deployment changes.

BYK and others added 3 commits October 6, 2026 14:36
Replace CLI Biome and Ultracite rules with Oxlint and Oxfmt while retaining command, database, import, and silent-catch checks.

Co-Authored-By: GPT-6 Sol <agent@openai.com>
Co-Authored-By: GPT-6 Sol <agent@openai.com>
Co-Authored-By: GPT-6 Sol <agent@openai.com>
Comment thread packages/cli/test/lib/api-client.multiregion.test.ts Fixed
Comment thread packages/cli/test/lib/api-client.multiregion.test.ts Fixed
@BYK
BYK deployed to Actions October 6, 2026 15:04 — with GitHub Actions Active
Co-Authored-By: GPT-6 Sol <agent@openai.com>
@BYK
BYK deployed to Actions October 6, 2026 15:12 — with GitHub Actions Active
Use parsed URL origins in multi-region assertions and the CLI's existing color and ANSI normalization in formatter tests to clear CodeQL findings.

Co-Authored-By: GPT-6 Sol <agent@openai.com>
@BYK
BYK deployed to Actions October 6, 2026 15:38 — with GitHub Actions Active
@BYK
BYK merged commit 517f1c6 into main Oct 6, 2026
34 of 35 checks passed
@BYK
BYK deleted the chore/remove-biome branch October 6, 2026 15:59

This branch was successfully deployed

1 active deployment
Actions — b5a520e4 Deployed Oct 6, 2026 by BYK via eval #1245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants