refactor(init): use markdown pipeline for spinner messages#686
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1476 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.45% 95.46% +0.01%
==========================================
Files 223 223 —
Lines 32502 32510 +8
Branches 0 0 —
==========================================
+ Hits 31022 31034 +12
- Misses 1480 1476 -4
- Partials 0 0 —Generated by Codecov Action |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Pipe spinner messages through the markdown rendering pipeline so file names, commands, and project names display as styled inline code in the terminal. Truncation happens on the plain markdown source before rendering, keeping truncateForTerminal simple. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
betegon
force-pushed
the
refactor/spinner-markdown-pipeline
branch
from
2f55b63 to
6bc04a4
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7c94eb8. Configure here.
Address review feedback: - Use safeCodeSpan() to safely wrap values in backtick code spans, handling values that may contain backticks, pipes, or newlines. - Strip unmatched trailing backtick after truncation so renderInlineMarkdown doesn't produce a literal ` character. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MathurAditya724
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderInlineMarkdownso file names, commands, and project names render as styled inline code (backticks→ ANSI code spans)truncateForTerminalto measure visible width viastripAnsi, preserving ANSI sequences during truncationTest plan
wizard-runner.test.tstests passsentry-cli initand verify spinner messages show styled file/command names🤖 Generated with Claude Code