Video autoposter#2000
Open
cweiske wants to merge 2 commits into
Open
Conversation
Author
|
The code requires PHP 7.0 because of |
Member
|
Yes its a problem. Grav currently supports 5.5+ Also this also contains your mimetype PR from a previous PR request, and that needs to me modified to support codecs. |
Author
|
I've replaced the PHP7-only code with the |
The image file will be added as poster attribute to the video tag. Looks for the following files in the video folder: - $filename.jpg - $filename.png - $filename.$ext.thumb.jpg - $filename.$ext.thumb.png The code is hacky but works for me, and I don't know the Grav API good enough to do it better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically detect video thumbnail
The image file will be added as poster attribute to the video tag.
Looks for the following files in the video folder:
The code is hacky but works for me, and I don't know the Grav API good enough
to do it better.
It's currently based on #1992 but can be used without it.