chore: port pending executor and release hardening - #38
Merged
Merged
Conversation
A directory descriptor kept an owned string per path component while its RAM charge is the flat per-descriptor one, so the resident cost ran well ahead of what was metered. The table is per-VFS and interning deduplicates, so reopening the same path cannot grow it, and every component it can hold names a trie node whose name `MapFile` already charged.
Every distinct address a contract asked about was kept for the whole run, off any limiter: measured 141 octets per entry at 28k inserts per second, so a plain loop turned wall-clock into unmetered RSS. Bounding beats charging here because the entry outlives the sub-VM that inserted it, so a per-VM charge would be released while the entry stayed resident, and routing it to a shared limiter would breach the separate deterministic and non-deterministic budgets. Evicting is free of consequence: the host answers from a fixed pre-state and in-run changes are applied on top, so a miss costs a round trip, never a different answer.
gl_call and the named-struct Decode derive both materialized `Maybe` fields through an intermediate `Value`, so emissions were charged for their encoded length but retained a ~39x larger tree for the whole run.
Per-argument wrappers and allocations let flat calldata outgrow its wire-based RAM charge. Retain each validated argument collection as one buffer while preserving its encoding and enclosing depth budget.
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened executor mirror of genlayerlabs/genvm-manager#36.
Carries the executor-side work for that manager PR. The manager branch update fast-forwards
v0.3-devto its pinned commit after landing.